[codex] Soften plugin signal verification#181
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92fe7cf0f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| print( | ||
| f"Warning: {service}:{env_name} expected schema {expected_schema}, " | ||
| f"got {signal.get('schema_version')!r} at {signal_path}; " | ||
| "strategy runtime will ignore the plugin until it is fixed." | ||
| ) |
There was a problem hiding this comment.
When a mount sets expected_schema_version and the artifact is otherwise valid JSON with the wrong schema, this now only warns and the workflow proceeds. I checked the runtime path wired in main.py (parse_strategy_plugin_mounts / load_configured_strategy_plugin_signals from the vendored quant_platform_kit), and that loader does not consume expected_schema_version, so it will not ignore the plugin as this message says; it can load an incompatible signal into strategy execution instead of falling back to the base plan.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
python3 -m py_compile scripts/verify_cloud_run_strategy_plugin_mounts.py